Limit surcharge checkout refresh to gateways with active surcharge#1202
Open
extenlab wants to merge 4 commits intomollie:dev/developfrom
Open
Limit surcharge checkout refresh to gateways with active surcharge#1202extenlab wants to merge 4 commits intomollie:dev/developfrom
extenlab wants to merge 4 commits intomollie:dev/developfrom
Conversation
…fresh-for-mollie Limit surcharge checkout refresh to gateways with active surcharge
…ted_checkout Reset tracked payment method on checkout updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR limits the classic checkout refresh triggered by the Mollie surcharge script.
Previously, the surcharge script triggered
update_checkouton everyinput[name="payment_method"]change, including non-Mollie gateways. This caused unnecessary checkout refreshes when switching between payment methods that cannot affect Mollie surcharge totals.The refresh is now only triggered when the previous or current payment method is a Mollie gateway with active
payment_surchargesettings. It also keeps the previous payment method state in sync afterupdated_checkout.Order-pay surcharge handling is unchanged.
Testing
Manually tested on classic checkout with:
payment_surcharge = no_feeVerified that:
payment_surcharge = no_feedo not trigger the surcharge refresh